Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document fixed-table shortcode, update column-list shortcode #918

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

docs/sources/write/shortcodes/index.md Outdated Show resolved Hide resolved
docs/sources/write/shortcodes/index.md Outdated Show resolved Hide resolved
docs/sources/write/shortcodes/index.md Outdated Show resolved Hide resolved
docs/sources/write/shortcodes/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need more info on how to use this shortcode.

docs/sources/write/shortcodes/index.md Outdated Show resolved Hide resolved
@@ -716,6 +722,44 @@ Headings are offset by one level, so if the source content contains an `h1`, the
{{</* docs/shared lookup="shared-page.md" source="enterprise-metrics" version="<GEM_VERSION>" leveloffset="+1" */>}}
```

## Fixed-table

The `fixed-table` shortcode allows the column contents to be wrapped to a new line at any character.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still more questions. Presumably you can specify the width of the table or column to define when the wrapping is supposed to begin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying the fixed (character?) width of a column would be super useful... and would resolve other issues I've trying to work around.

Copy link
Contributor Author

@robbymilo robbymilo Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this time we do not have a way to specify the width of a column as we would have to consider how it works with desktop, mobile, etc. breakpoints.

I've clarified this line in c2fadb5.

docs/sources/write/shortcodes/index.md Show resolved Hide resolved
@robbymilo robbymilo requested a review from JStickler December 10, 2024 08:35
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
@robbymilo
Copy link
Contributor Author

Thanks for the assist @jdbaldry!

@robbymilo
Copy link
Contributor Author

Will merge once we get a new docs-base image published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants